Related app/team name: Champ Select Coach (although the issue is not app-relevant)
Issue Description:
The recommended manual update flow is described in https://overwolf.github.io/docs/api/overwolf-extensions#recommended-extension-update-flow and is working correctly unless the channel is changed while the app is running and both channels have identical opk-s. In that case the app gets stuck in a state where extensions.checkForExtensionUpdate
returns UpdateAvailable
even though the app is already in the latest version and even after successful calls to overwolf.extensions.updateExtension
. The expected behavior should be that extensions.checkForExtensionUpdate
returns UpToDate
(or at least PendingRestart
).
Can you reproduce it (exact steps to reproduce):
Yes
- [Uninstall CSC]
- Install CSC
- Go to CSC settings and press Check for updates (it works, says the app is up to date because
overwolf.extensions.updateExtension
returnsUpToDate
) - Click ‘Enable experimental features’ (this swaps CSC back and forth between the channel “Beta” and channel “0” - prod)
-
overwolf.extensions.updateExtension
returnsUpdateAvailable
, so the “Download update” link is available. (Incorrect because the opk is the same - so already up to date) - Click “Download update”, this calls
overwolf.extensions.updateExtension
, whose result is written to console.log (written to the “mainWindow” log:{"info":"new version 0.1.12.2 installed, restart app to apply.","state":"PendingRestart","success":true}
). Then CSC callsextensions.checkForExtensionUpdate
again but it still returnsUpdateAvailable
so the flow is stuck. - [Disable “Enable experimental features” and then the app is swapped back to “0”, and
extensions.checkForExtensionUpdate
now returnsUpToDate
once again.]
Currently the “Beta” and “0” channels have the exact same opk, and previously when they weren’t this has worked (it would say update available then pending restart and after restart it would actually swap to the correct version depending on the chosen channel), so I believe this is a condition as well.
Impact for my app:
Not critical
Do you currently have a workaround?
It is up to date, just can’t get rid of the warning “The app is not up to date” for users testing Beta
OverwolfLogs_2021-06-21_09-53-09.zip (771.0 KB)
Time when overwolf.extensions.updateExtension
returned in the logs: 09:51:51,330