Issue Description: some of my goals are reported twice, once as a goal and once as a team goal. some of them are even reported as team goals only.
Steps to reproduce: score some goals
Impact for my app: mid
Do you currently have a workaround? nopeOverwolfLogs_2020-11-08_09-49-23.zip (2.2 MB)
@LeshM, which version of the game are you using? If it’s the new Epic version, there are some issues. We are working on a fix.
oh sorry forgot to mention.
It’s on steam.
I stopped using the epic version as all of the events were “opposing team goal”.
@LeshM, where precisely in the logs can I find the time you got teamGoal and opposing team goal events for the same goal?`
2020-11-07 23:46:06,279 (INFO) On Game highlight (10798): feature [goal] data [goal]
2020-11-07 23:46:06,280 (INFO) Start New replay
2020-11-07 23:46:06,280 (INFO) Start capture replay. trigger data [name: goal, past: 12000, data:goal]
2020-11-07 23:46:06,281 (INFO) On Game highlight (10798): feature [teamGoal] data [teamGoal]
2020-11-07 23:46:06,281 (INFO) Adding event to active replay. trigger data [name: teamGoal, past: 12001, data:teamGoal reset:False]. estimate replay length: 25001. estimate stop time: 11/07/2020 23:46:31
2020-11-07 23:46:06,282 (INFO) start stop time. internal: 25000 stop time: 11/07/2020 23:46:31
2020-11-07 23:46:06,281 (INFO) start stop time. internal: 25000 stop time: 11/07/2020 23:46:31
2020-11-07 23:46:31,283 (INFO) Stop capture replay
2020-11-07 23:46:31,283 (INFO) Stop capture replay
2020-11-07 23:46:31,989 (INFO) Highlight video 'C:/Users/omerl/Videos/Overwolf\Fuze.tv\Rocket League\Rocket League_11-07-2020_21-48-36-032\Rocket League 11-07-2020 23-46-06-280.mp4' needs compilation [delta:12815]
2020-11-07 23:46:31,990 (INFO) rename file before composition video: C:/Users/omerl/Videos/Overwolf\Fuze.tv\Rocket League\Rocket League_11-07-2020_21-48-36-032\Rocket League 11-07-2020 23-46-06-280.mp4
2020-11-07 23:46:31,991 (INFO) move file before trimming C:/Users/omerl/Videos/Overwolf\Fuze.tv\Rocket League\Rocket League_11-07-2020_21-48-36-032\Rocket League 11-07-2020 23-46-06-280.mp4 -> C:\Users\omerl\Videos\Overwolf\Fuze.tv\Rocket League\Rocket League_11-07-2020_21-48-36-032\Rocket League 11-07-2020 23-46-06-280_totrim.mp4
2020-11-07 23:46:31,991 (INFO) trim temp video file: C:\Users\omerl\Videos\Overwolf\Fuze.tv\Rocket League\Rocket League_11-07-2020_21-48-36-032\Rocket League 11-07-2020 23-46-06-280_totrim.mp4 -> C:/Users/omerl/Videos/Overwolf\Fuze.tv\Rocket League\Rocket League_11-07-2020_21-48-36-032\Rocket League 11-07-2020 23-46-06-280.mp4
2020-11-07 23:46:31,992 (INFO) Notify Replay is ready: C:/Users/omerl/Videos/Overwolf\Fuze.tv\Rocket League\Rocket League_11-07-2020_21-48-36-032\Rocket League 11-07-2020 23-46-06-280.mp4 to dafpjodfmofenjonekfnkphpghegoekhfepmbmib
2020-11-07 23:46:31,993 (INFO) replay media event: {
"game_id": 10798,
"match_id": "af58e78a-8341-418c-a7a5-ea468bf5bef9",
"match_internal_id": "43ce0d00-b8be-47dd-987d-6a170d349f50",
"session_id": "6bc24cf9f1664e9b9e8b57f97345207f",
"session_start_time": 1604778512148,
"match_start_time": 1604785245197,
"start_time": 1604785554280,
"duration": 25001,
"events": [
"goal",
"teamGoal"
],
"raw_events": [
{
"type": "goal",
"time": 12000
},
{
"type": "teamGoal",
"time": 12001
}
],
"media_url": "overwolf://media/replays/Fuze.tv/Rocket+League/Rocket+League_11-07-2020_21-48-36-032/Rocket+League+11-07-2020+23-46-06-280.mp4",
"media_path": "C:/Users/omerl/Videos/Overwolf\\Fuze.tv\\Rocket League\\Rocket League_11-07-2020_21-48-36-032\\Rocket League 11-07-2020 23-46-06-280.mp4",
"media_path_encoded": "file:///C:/Users/omerl/Videos/Overwolf/Fuze.tv/Rocket League/Rocket League_11-07-2020_21-48-36-032/Rocket League 11-07-2020 23-46-06-280.mp4",
"thumbnail_url": "overwolf://media/thumbnails/Fuze.tv/Rocket+League/Rocket+League_11-07-2020_21-48-36-032/Rocket+League+11-07-2020+23-46-06-280.mp4",
"thumbnail_path": "C:\\Users\\omerl\\Videos\\Overwolf\\Fuze.tv\\Rocket League\\Rocket League_11-07-2020_21-48-36-032\\Thumbnails\\Rocket League 11-07-2020 23-46-06-280.jpg",
"thumbnail_encoded_path": "file:///C:/Users/omerl/Videos/Overwolf/Fuze.tv/Rocket League/Rocket League_11-07-2020_21-48-36-032/Thumbnails/Rocket League 11-07-2020 23-46-06-280.jpg",
"replay_video_start_time": 1604785553592
}
2020-11-07 23:46:31,993 (INFO) Notify replay to consumer [dafpjodfmofenjonekfnkphpghegoekhfepmbmib] is ready.
2020-11-07 23:46:31,994 (INFO) copy replay to consumer folder: C:\Users\omerl\Videos\Overwolf\Fuze.tv (local)\Rocket League\Rocket League_11-07-2020_21-48-37-536\Rocket League 11-07-2020 23-46-06-280.mp4 - C:/Users/omerl/Videos/Overwolf\Fuze.tv (local)\Rocket League\Rocket League_11-07-2020_21-48-37-536\Thumbnails\Rocket League 11-07-2020 23-46-06-280.jpg
2020-11-07 23:46:31,995 (ERROR) Notify replay media event to: edigpkamaofijkhiiekdjnoonaekchdlajkhgemaSystem.IO.FileNotFoundException: Could not find file 'C:/Users/omerl/Videos/Overwolf\Fuze.tv\Rocket League\Rocket League_11-07-2020_21-48-36-032\Rocket League 11-07-2020 23-46-06-280.mp4'.
File name: 'C:/Users/omerl/Videos/Overwolf\Fuze.tv\Rocket League\Rocket League_11-07-2020_21-48-36-032\Rocket League 11-07-2020 23-46-06-280.mp4'
at System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath)
at System.IO.File.InternalCopy(String sourceFileName, String destFileName, Boolean overwrite, Boolean checkHost)
at OverWolf.Client.Core.Capture.Replays.Highlights.HighlightsSession.CopyAndNotifyReplayEvent(JObject eventInfo, ActiveReplay replay, IHighlightsConsumer consumer)
Looks like there’s an error for every captured highlight:
2020-11-07 23:46:31,995 (ERROR) Notify replay media event to: edigpkamaofijkhiiekdjnoonaekchdlajkhgemaSystem.IO.FileNotFoundException: Could not find file ‘C:/Users/omerl/Videos/Overwolf\Fuze.tv\Rocket League\Rocket League_11-07-2020_21-48-36-032\Rocket League 11-07-2020 23-46-06-280.mp4’.
File name: ‘C:/Users/omerl/Videos/Overwolf\Fuze.tv\Rocket League\Rocket League_11-07-2020_21-48-36-032\Rocket League 11-07-2020 23-46-06-280.mp4’
at System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath)
at System.IO.File.InternalCopy(String sourceFileName, String destFileName, Boolean overwrite, Boolean checkHost)
at OverWolf.Client.Core.Capture.Replays.Highlights.HighlightsSession.CopyAndNotifyReplayEvent(JObject eventInfo, ActiveReplay replay, IHighlightsConsumer consumer)
@LeshM I will look at that in detail first thing in the morning tomorrow and let you know.
Thanks for your patience.
@LeshM Yesterday evening, we released a new GEP that fixed several RL issues (including a fix for the Epic store version, BTW).
Can you please retest and see if the error is still reproduced? If so, please write here the exact steps to reproduce.
Thanks.
the epic store version now report my goals correctly but this issue still remains.
I get double events for goals (one is “goal” and another is “team goal”)
This still happens, I added a workaround on our end that trims goals + teamGoals that are less than 10 milliseconds apart, in the same highlight.
local player goal and team goal are being fired simultaneously (and that’s just fine).
With your permission, I will close the issue now.
I’m sorry but how and why is this fine?
This logic developed like this from the beginning:
as we see it, when your team scores a goal, it can be your goal or other team’s member goal.
So we have two events here that one contains the other.
We leave the logic to handle it for your app. As there are apps that want to separate it, and apps want to get the two events together.
Ok I understand.
But if both events should be reported for the SAME goal, why are the timestamps different?
We are talking about small timestamps differences. Without deep dive into details, the root cause is how we are reading these specific events from the game. It’s not that we are getting a single event, and we split it into two and trigger goal + team goal: we are reading two different sources of info, which is the reason for the small timestamps differences.